Skip to content

test(linter): add test for Message::from_tsgo_lint_diagnostic#13254

Merged
graphite-app[bot] merged 1 commit intomainfrom
08-21-test_linter_add_test_for_message_from_tsgo_lint_diagnostic_
Aug 21, 2025
Merged

test(linter): add test for Message::from_tsgo_lint_diagnostic#13254
graphite-app[bot] merged 1 commit intomainfrom
08-21-test_linter_add_test_for_message_from_tsgo_lint_diagnostic_

Conversation

@Sysix
Copy link
Member

@Sysix Sysix commented Aug 21, 2025

No description provided.

@github-actions github-actions bot added A-linter Area - Linter C-test Category - Testing. Code is missing test cases, or a PR is adding them labels Aug 21, 2025
This was referenced Aug 21, 2025
Merged
Merged
Merged
Merged
@Sysix Graphite App
Copy link
Member Author

Sysix commented Aug 21, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Sysix Sysix mentioned this pull request Aug 21, 2025
Merged
@Sysix Sysix changed the base branch from 08-20-refactor_linter_move_lsp_relevant_code_into_own_file to graphite-base/13254 August 21, 2025 19:17
@Sysix Sysix force-pushed the graphite-base/13254 branch from 2328790 to a1b52c8 Compare August 21, 2025 19:17
@Sysix Sysix force-pushed the 08-21-test_linter_add_test_for_message_from_tsgo_lint_diagnostic_ branch from 5db29eb to f35e705 Compare August 21, 2025 19:17
@Sysix Sysix changed the base branch from graphite-base/13254 to main August 21, 2025 19:17
@codspeed-hq
Copy link

codspeed-hq bot commented Aug 21, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #13254 will not alter performance

Comparing 08-21-test_linter_add_test_for_message_from_tsgo_lint_diagnostic_ (30c54a3) with main (a1b52c8)1

Summary

✅ 34 untouched benchmarks

Footnotes

  1. No successful run was found on main (30c54a3) during the generation of this report, so a1b52c8 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@Sysix Sysix force-pushed the 08-21-test_linter_add_test_for_message_from_tsgo_lint_diagnostic_ branch from f35e705 to 8a1a843 Compare August 21, 2025 19:22
@Sysix Sysix marked this pull request as ready for review August 21, 2025 19:28
Copilot AI review requested due to automatic review settings August 21, 2025 19:28
@Sysix Sysix requested a review from camc314 as a code owner August 21, 2025 19:28
Copilot AI reviewed Aug 21, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds comprehensive unit tests for the Message::from_tsgo_lint_diagnostic function, which converts TypeScript Go lint diagnostics into internal Message objects. The tests verify both basic diagnostic conversion and diagnostic conversion with fixes.

  • Adds unit tests for Message::from_tsgo_lint_diagnostic function
  • Implements PartialEq trait for PossibleFixes to enable test assertions
  • Refactors imports to use conditional compilation for test-only dependencies

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Sysix Sysix force-pushed the 08-21-test_linter_add_test_for_message_from_tsgo_lint_diagnostic_ branch from 8a1a843 to 713d47a Compare August 21, 2025 19:43
@Sysix Sysix mentioned this pull request Aug 21, 2025
Merged
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Aug 21, 2025
@camc314 Graphite App
Copy link
Contributor

camc314 commented Aug 21, 2025 •
edited by graphite-app bot
Loading

Merge activity

@graphite-app graphite-app bot force-pushed the 08-21-test_linter_add_test_for_message_from_tsgo_lint_diagnostic_ branch from 713d47a to 30c54a3 Compare August 21, 2025 20:15
@graphite-app graphite-app bot merged commit 30c54a3 into main Aug 21, 2025
24 checks passed
@graphite-app graphite-app bot deleted the 08-21-test_linter_add_test_for_message_from_tsgo_lint_diagnostic_ branch August 21, 2025 20:19
This was referenced Aug 26, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@camc314 camc314 camc314 approved these changes

Assignees

No one assigned

Labels

0-merge Merge with Graphite Merge Queue A-linter Area - Linter C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Sysix @camc314